Subject: BUG #3790: pg_restore error canceling statement due touser request
From: tgl@sss.pgh.pa.us (Tom Lane)
Date: 12/4/2007 10:32:09 AM
Gregory Stark <stark@enterprisedb.com> writes:
> I guess we should capture this error with a PG_TRY and silently abort instead.
> Just a NOTICE or INFO should be sufficient. Other errors should of course be
> rethrown.
This falls in the category of "destabilizing the code for purely
cosmetic reasons", and would be a foolish change to make at RC1 time.
We could change the text of the ERROR message reasonably easily,
but changing the basic transaction abort method is right out.
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster
Subject: BUG #3790: pg_restore error canceling statement due touser request
From: tgl@sss.pgh.pa.us (Tom Lane)
Date: 12/4/2007 10:07:44 PM
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I don't advocate changing that ERROR to anything else. The message
> wording, as Tom says, can easily be changed -- I think this patch should
> be enough. Feel free to propose better wording.
Minor gripe: all three variants of the message should follow the same
sentence construction. So perhaps "canceling autovacuum task".
Other than the wording issue, this seems about the right fix to me.
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?
http://www.postgresql.org/docs/faq
Subject: BUG #3790: pg_restore error canceling statement due touser request
From: tgl@sss.pgh.pa.us (Tom Lane)
Date: 12/6/2007 10:19:15 AM
Simon Riggs <simon@2ndquadrant.com> writes:
> True. We can say "task will be automatically re-scheduled", so that
> people understand the message and don't start asking us.
How about "temporarily canceling autovacuum task"? This is accurate
regardless of the origin of the SIGINT.
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend
|