Subject: BUG #3760: Comment on restore database
From: tgl@sss.pgh.pa.us (Tom Lane)
Date: 11/19/2007 6:38:51 PM
Simon Riggs <simon@2ndquadrant.com> writes:
> Reason to do this now: Perf Tips have been changed for 8.3 to recommend
> using --single-transaction when restoring pg_dumps, because of fast COPY
> enhancement. Allowing this to cause an error will prevent the whole dump
> from restoring.
If it were indeed an error condition, this argument might have some
merit. Since it is not, I don't have a lot of sympathy for a hasty
last-minute change.
regression=# comment on database foo is 'z';
WARNING: database "foo" does not exist
COMMENT
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at
http://www.postgresql.org/about/donate
Subject: BUG #3760: Comment on restore database
From: tgl@sss.pgh.pa.us (Tom Lane)
Date: 11/19/2007 6:40:09 PM
Bruce Momjian <bruce@momjian.us> writes:
> I have added a TODO item:
> o Allow COMMENT ON dbname to work when loading into a database
> with a different name
This is an extremely poorly phrased TODO item. The problem is not that
you can't comment on a database with a different name --- that's worked
ever since pg_shdescription was added.
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?
http://archives.postgresql.org
Subject: BUG #3760: Comment on restore database
From: tgl@sss.pgh.pa.us (Tom Lane)
Date: 11/19/2007 7:14:01 PM
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> This is an extremely poorly phrased TODO item.
> OK, updated:
> o Prevent COMMENT ON dbname from issuing a warning when loading
> into a database with a different name, perhaps using COMMENT ON
> CURRENT DATABASE
That's not any better, because the warning isn't the problem either.
Perhaps:
o Change pg_dump so that any comment on the dumped database is
applied to the database the dump is loaded into, even if
its database name is different. This will require new
backend syntax, perhaps COMMENT ON CURRENT DATABASE.
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster
|