Wasn't this patch http://archives.postgresql.org/pgsql-committers/2007-11/msg00170.php supposed to fix things so that we wouldn't be throwing NOTICEs out of tsearch dictionary init functions? It seems to have gotten only one of the two elog(NOTICE) calls in there. The other one is for a stopword in the replacement phrase. Is there any objection to making that an ERROR too? Also, several of the elog's in this file ought to be ereport's since they are user-caused error conditions. I think we are nominally past string freeze, but does anyone have an objection to changing them to ereport's? If they don't get translated, the worst that will happen is that they come out in English, which is what's happening now. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Bruce Momjian <bruce@momjian.us> writes: > Thanks, working on this now. Because the stop words can be any stop > word I didn't imagine it could be in the subsitution. What stop word > will it use? Anyway, coding it now to match the left-hand-side. Why would you do that? There is not any corresponding idea of leaving holes in the pattern. AFAICS the only change needed is NOTICE->ERROR. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > FYI, at this time only the German and French translations have been > updated almost fully, and none of them is yet 100% in the backend > translation. I think it's appropriate to mark this string for > translation at this time (i.e. turn it into an ereport call). Yeah, I saw a number of elogs that should be ereports in the tsearch code during some idle looking yesterday. I'm planning to go through it a bit more systematically today and fix what needs fixing. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match