Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > I didn't check the rest of the patch, but did you verify that it still > works in VPATH builds? Actually, it looks to me like the patch is wrong specifically because it does not do the right thing in the VPATH case. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings

Jorgen Austvik <Jorgen.Austvik@Sun.COM> writes: > Tom Lane wrote: >> Actually, it looks to me like the patch is wrong specifically because >> it does not do the right thing in the VPATH case. > Are you thinking about "failing if the folders are missing" as "not the > right thing in the VPATH case", or are you thinking about something else? The point is that in VPATH you are running in a build tree, and should copy the source files from the source tree, but *not* modify the source tree. Thus, fetching relative to $srcdir but writing relative to . is in fact the correct behavior. There has not previously been any complaint that pg_regress was broken in this regard, so maybe you should take two steps back and explain what problem you think needs fixing, rather than just dropping a patch on us. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to majordomo@postgresql.org so that your message can get through to the mailing list cleanly

Jorgen Austvik <Jorgen.Austvik@Sun.COM> writes: > But if we have set srcdir, the directory we are stat'ing, is not the > same directory that we are reading the files from: Ah. The reason this works in VPATH mode is that setup of the build tree duplicated all subdirectories of the source tree, so ./input/ should exist iff $srcdir/input/ does. I agree it's a bit ugly though; it'd be better to stat what we really plan to read. Maybe push the stat operation inside convert_sourcefiles_in ? regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings

Jorgen Austvik - Sun Norway <Jorgen.Austvik@Sun.COM> writes: > this patch should only move the stat operation into > convert_sourcefiles_in(). Applied, thanks. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match