Subject: Re: [COMMITTERS] pgsql: GIN index build's allocatedMemory counter needs to be long, not
From: tgl@sss.pgh.pa.us (Tom Lane)
Date: 11/18/2007 3:57:59 PM
Peter Eisentraut <peter_e@gmx.net> writes:
> Jeremy Drake wrote:
>> I don't know if this has been discussed before, but you are aware that it
>> is not dictated by the C standard that sizeof(long) == sizeof(void*)?
> Yes, and there is lots of work left to do to support that.
Yeah. The current code convention is to use "long" when counting space
allocations --- see tuplesort.c for instance --- so I made this do
likewise. At some point we should try to migrate away from that,
but not today.
regards, tom lane
---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings
|